Do not pass the module_repository in PE >=3.2 #190
Conversation
These versions of Puppet Enterprise talk to the v3 forge API which is not present at http://forge.puppetlabs.com which is the default in Puppetfiles created by librarian puppet. This will break installs from pulp and should be reconsidered when pulp and librarian-puppet are updated to support the v3 forge api(https://forgeapi.puppetlabs.com). In addition newer versions of PMT enforce some additional rules when installing modules that probably don't make sense if validation is being done inside librarian-puppet. Instead of --ignore-dependencies librarian should use --force.
|
I'd like to throw my support for this pull request in here as we're an org currently affected by the issue. Right now we're using a hand-rolled LP, but would love to move back to the community gem. |
|
Thanks for the PR. I've implemented it a bit differently to handle the v3 api, can you check that the branch api-v3 looks good for you? |
|
This change was in 3.2.0 so the following should be >= not > I think. if pe_version and Gem::Version.create(pe_version[1].strip) > Gem::Version.create('3.2.0') Other than that it looks fine. |
|
gotcha, thanks. Trying to release 1.0.0 and then this goes next |
|
@MasonM I noticed the error, and had to merge the latest changes in master, can you check api-v3 again? If that looks good I'll merge and release |
|
@carlossg Yep, those latest commits fixed it. Thanks! |
…3 API Swap http://forge.puppetlabs.com to https://forgeapi.puppetlabs.com on the fly Avoid executing puppet several times Create a new puppet_gem_version method for comparisons
|
Merged in bd29b9f |
These versions of Puppet Enterprise talk to the v3 forge API which is
not present at http://forge.puppetlabs.com which is the default in
Puppetfiles created by librarian puppet. This will break installs from
pulp and should be reconsidered when pulp and librarian-puppet are
updated to support the v3 forge api(https://forgeapi.puppetlabs.com).
In addition newer versions of PMT enforce some additional rules when
installing modules that probably don't make sense if validation is being
done inside librarian-puppet. Instead of --ignore-dependencies librarian
should use --force.